Skip to content

Conversation

@MarcelRosier
Copy link
Collaborator

Migrate logging to loguru

@MarcelRosier MarcelRosier self-assigned this Jul 22, 2025
Copilot AI review requested due to automatic review settings July 22, 2025 10:08
@MarcelRosier MarcelRosier linked an issue Jul 22, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the logging system from a custom logging implementation to loguru library for improved logging functionality and consistency.

  • Replaces custom LoggingManager with loguru's simpler logging interface
  • Updates all imports across the codebase to use loguru logger
  • Removes the custom logging_utils.py module entirely

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Adds loguru dependency
brainles_preprocessing/utils/logging_utils.py Removes entire custom LoggingManager implementation
brainles_preprocessing/utils/zenodo.py Replaces custom logger with loguru import
brainles_preprocessing/transform.py Updates logger import to use loguru
brainles_preprocessing/preprocessor/preprocessor.py Migrates logging functionality to loguru with new file handler method
brainles_preprocessing/preprocessor/native_space_preprocessor.py Updates run method to use loguru file handlers
brainles_preprocessing/preprocessor/atlas_centric_preprocessor.py Updates run method to use loguru file handlers
brainles_preprocessing/modality.py Replaces standard logging with loguru import

@MarcelRosier MarcelRosier requested a review from neuronflow July 22, 2025 10:10
@neuronflow neuronflow merged commit ba9ef14 into main Jul 23, 2025
4 checks passed
@neuronflow neuronflow deleted the 144-feature-optimize-logging branch July 23, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] optimize logging

3 participants