Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uuid mismatch when wrapping obj #11

Merged
merged 4 commits into from
Jan 7, 2025
Merged

fix uuid mismatch when wrapping obj #11

merged 4 commits into from
Jan 7, 2025

Conversation

BradyAJohnston
Copy link
Owner

@BradyAJohnston BradyAJohnston commented Jan 7, 2025

If we wrap an object in BlenderObject that already has a UUID, then we now take on that existing UUID instead of re-assigning one leading to loss of sync with databases.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.73%. Comparing base (ba02e36) to head (145cf57).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
databpy/object.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   60.19%   60.73%   +0.53%     
==========================================
  Files           9        9              
  Lines         510      517       +7     
==========================================
+ Hits          307      314       +7     
  Misses        203      203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyAJohnston BradyAJohnston merged commit c0f0509 into main Jan 7, 2025
5 checks passed
@BradyAJohnston BradyAJohnston deleted the bob-uuid branch January 7, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant