Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement jump to definition for type aliases #1287

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

antoniosarosi
Copy link
Contributor

@antoniosarosi antoniosarosi commented Jan 1, 2025

Important

Implement jump to definition for type aliases by adding support in runtime, IR, and walkers.

  • Behavior:
    • Implement jump to definition for type aliases in runtime_wasm/mod.rs by adding support in search_for_symbol().
    • Add find_type_alias() to IRHelper trait in ir_helpers/mod.rs.
  • Models:
    • Add TypeAlias struct to repr.rs.
    • Add TypeAliasWalker to walkers/mod.rs and alias.rs.
  • Misc:
    • Add walk_type_aliases() to IntermediateRepr in repr.rs.
    • Add TypeAlias to ir/mod.rs type aliases.

This description was created by Ellipsis for 7200129. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 10:04pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7200129 in 21 seconds

More details
  • Looked at 251 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. engine/baml-schema-wasm/src/runtime_wasm/mod.rs:1219
  • Draft comment:
    Redundant variable assignment. The variable _uri_str is assigned but not used. Consider removing it.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds functionality to find type aliases and jump to their definitions. However, there is a redundant variable assignment in the search_for_symbol function for type aliases.

Workflow ID: wflow_RzJEMdoID1dpnKtR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@antoniosarosi antoniosarosi added this pull request to the merge queue Jan 1, 2025
Merged via the queue into canary with commit 6cb5009 Jan 1, 2025
10 of 11 checks passed
@antoniosarosi antoniosarosi deleted the antonio/type-alias-jump-to-definition branch January 1, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant