Conversation
Owner
Author
|
The CI failure is legit ... linking with the |
f89c05c to
7c6c216
Compare
Owner
Author
|
CI still failing because of microsoft/windows-rs#142 Merging this PR is not urgent, so I think we can just wait until that is fixed. |
|
Have you tried the latest version of winrt-rs? We don't link directly against onecore.lib anymore. |
Owner
Author
|
Thanks for the hint! The CI is green, so this seems to work now 👍 I'm going to merge this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest version of the "winrt" crate, which is now maintained by Microsoft (https://github.com/microsoft/winrt-rs).