#58: [CS5] Move RepeatMode display properties out of LibraryView.swift - #77
Open
KyNorthstar wants to merge 1 commit into
Open
#58: [CS5] Move RepeatMode display properties out of LibraryView.swift#77KyNorthstar wants to merge 1 commit into
KyNorthstar wants to merge 1 commit into
Conversation
`displayName`, `systemImageName_menuItem`, and `systemImageName_preview` lived in a private extension at the bottom of LibraryView.swift instead of beside RepeatMode itself. Moved them to a new RepeatMode + display.swift, following the same Type + purpose.swift pattern already used by NativeImage + placeholder.swift and NativeImage + thumbnail.swift. No logic changes. Both call sites in LibraryView.swift still resolve against the new public extension. Fixes #58 Co-authored-by: Claude 5 Opus <feedback+claude@kynorthstar.me>
KyNorthstar
added
the
Automatically found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
RepeatMode'sdisplayName,systemImageName_menuItem, andsystemImageName_previewout of aprivate extensionat the tail ofLibraryView.swiftand into a newMedia Player/RepeatMode + display.swift,beside
RepeatMode.swiftitself.Why
Closes #58. These properties describe
RepeatMode, notLibraryView—they were only in that file because that's where they were first needed.
The repo already has a convention for this (
NativeImage + placeholder.swift,NativeImage + thumbnail.swift), so this follows existing pattern ratherthan introducing a new one.
Changes
Media Player/RepeatMode + display.swift— the threeproperties, now
public extension RepeatMode(matches the visibilityof
RepeatMode.cycleNext(), since they're called from outsideRepeatMode.swift's own file)UI/LibraryView.swift— deleted theprivate extensionblock and its
// MARK: - Sugarheader; nothing else touchedVerification
No build available in my environment — verified by inspection: confirmed
both call sites (
mode.displayName/mode.systemImageName_menuIteminthe repeat-mode picker,
session.repeatMode.systemImageName_previewinthe toolbar) resolve against the new public extension in the same target.
A real build/run is still worth doing before merge.
Journal:
LLM transparency/Claude Sonnet 5 • Issue #58 journal.mdFixes #58