Satisfy program with optional pruning #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to move away from the stringly-typed errors, but I guess that's independent of this PR. I'm gonna go ahead and ACK this -- I agree the name is a bit weird but the whole API right now is a bit undiscoverable and I think we want to do a pass through it and see if we can't reduce the number of exposed types and clarify their relationship. |
Comment on lines
+143
to
+146
| /// ## Errors | ||
| /// | ||
| /// - Witness values have a different type than declared in the Simfony program. | ||
| /// - There are missing witness values. |
There was a problem hiding this comment.
30f125f: nit: pruning fails if the program doesn't run successfully for the given environment and witness data. This is an additional error path, next to the existing two paths.
apoelstra
added a commit
to apoelstra/s-lang
that referenced
this pull request
Apr 29, 2025
30f125f Satisfy program with optional pruning (Michael Zaikin) Pull request description: This PR exposes an API for satisfying a program with pruning given an optional environment. The naming might be a bit misleading (maybe `satisfy_pruned` would be better?), pls let me know if you want to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes an API for satisfying a program with pruning given an optional environment.
The naming might be a bit misleading (maybe
satisfy_prunedwould be better?), pls let me know if you want to change.