Skip to content

Optionally disable debug symbols #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

Optionally disable debug symbols #124

merged 2 commits into from
Apr 24, 2025

Conversation

uncomputable
Copy link
Collaborator

Fixes #115

@uncomputable uncomputable force-pushed the 2025-04-disable-debug branch from 3188f74 to 23cd66e Compare April 23, 2025 22:51
@apoelstra
Copy link
Contributor

cc @canndrew can you review this?

apoelstra
apoelstra approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 23cd66e; successfully ran local tests

@canndrew
Copy link
Contributor

LGTM except that you might want the option to enable debug symbols when building with simc. I guess that can be left for a follow-up PR though.

@apoelstra apoelstra merged commit 2aeb2d4 into BlockstreamResearch:master Apr 24, 2025
13 checks passed
@uncomputable
Copy link
Collaborator Author

simc has been an afterthought for a while. It has a weird interface and hasn't received love for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile without debug symbols
3 participants
@uncomputable @apoelstra @canndrew