Skip to content

Remove unused context initializer functions #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomaseizinger
Copy link
Contributor

Fixes #15.

Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. now that we've stopped rebasing maybe these will stay gone :)

@apoelstra apoelstra merged commit ebf57dc into BlockstreamResearch:secp256k1-zkp Nov 24, 2020
@thomaseizinger
Copy link
Contributor Author

lol. now that we've stopped rebasing maybe these will stay gone :)

I wasn't aware! Did functions keep coming back from upstream?

@apoelstra
Copy link
Contributor

These functions existed a very long time ago, in Elements Alpha, before Elements had Confidential Asset support. @sipa and I spent some time in 2016 replacing the precomputation tables in the rangeproof code with non-precomp code, since our constant H generator was replaced by a variable asset generator as part of CA. But we forgot to remove the two precomputation functions from the header.

We noticed this some years later, and I swear I remember deleting them after that, but at some point a few rebases had gone by and I saw that they'd returned. This may have happened more than once, I don't remember now.

I deleted them again as part of #108 but you beat me to it :)

@apoelstra
Copy link
Contributor

lol, I realize that the rangeproof sign/verify functions still talk about needing a context "initialized for rangeproof and pedersen commitment"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context initializers
2 participants