benches: fix divmod_128_64 distribution #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2025-11/benchmark-divmod
branch
2 times, most recently
from
f7adad0 to
0f6cf69
Compare
Collaborator
Author
|
The new distribution is consistently slower than the uniform one. But all results are in a 40-60ns range; I see maybe a 10% slowdown rather than the 2x (or maybe 4x) that I would naively expect. But I added printfs to the C code to confirm that with the new distribution we are no longer hitting the "shortcut" case, while with the uniform distribution we are. So this is working. I think this is just a case where the marshalling cost is overwhelming the actual computation cost. |
jets-bench/src/input.rs
Outdated
|
|
||
| // To implement this, we sample two random 64-bit strings, with one of them | ||
| // having its high bit forced to 1. The higher of the two (which will always | ||
| // have its high bit 1) is ah, and the other one is b. |
Contributor
There was a problem hiding this comment.
The higher of the two is b.
apoelstra
force-pushed
the
2025-11/benchmark-divmod
branch
from
0f6cf69 to
9dc53e8
Compare
roconnor-blockstream
suggested changes
Nov 21, 2025
jets-bench/src/input.rs
Outdated
| } | ||
| unreachable!("if we get here, two uniform 63-bit samples were exactly equal") | ||
| } else { | ||
| panic!("invalid distribution {} for BIP 340 signature", dist) |
apoelstra
force-pushed
the
2025-11/benchmark-divmod
branch
from
9dc53e8 to
8cb7e03
Compare
roconnor-blockstream
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
div_mod_128_64jet has preconditions and shortcuts its operation if these are not met. To benchmark correctly we need to sample according to those preconditions.