Skip to content

Wasm build fails #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sanket1729 opened this issue Mar 16, 2022 · 4 comments · Fixed by #54
Closed

Wasm build fails #47

sanket1729 opened this issue Mar 16, 2022 · 4 comments · Fixed by #54

Comments

@sanket1729
Copy link
Member

See: rust-bitcoin/rust-secp256k1#419 for more context
@sanket1729 sanket1729 mentioned this issue Mar 16, 2022
Merged
@cryptoquick
Copy link

It looks like this PR was merged a couple days after the latest release of this library. It shouldn't be too much additional work to get this compiling on wasm32, correct?

@apoelstra
Copy link
Contributor

So, the relevant bug was avoided in 7055f4f (Dec 2020) which simply deletes the offending symbols from secp-zkp-sys, preferring instead to import them from secp-sys. So when rust-bitcoin/rust-secp256k1#419 (March 2021) was merged that fix should've propagated to here.

So I think we could've re-enabled WASM CI tests a long time ago.

I will backport rust-bitcoin/rust-secp256k1#422 to bring in some other CI improvements.

@apoelstra
Copy link
Contributor

BTW the main fix in #422 (using -e and not using &&) was implemented here already in #25 (July 2021)

@apoelstra apoelstra mentioned this issue Jul 25, 2022
Merged
@cryptoquick
Copy link

I see, thank you for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Backport rust-secp 284 and 422 BlockstreamResearch/rust-secp256k1-zkp
3 participants
@cryptoquick @apoelstra @sanket1729