Open
Conversation
* Model change - add "prefix" property * Change gtfs-import: importLines() change and another minor * test\import-gtfs.js fixed by linter
* Update README.md - prefixes info
Member
|
This will be a really useful feature. I don't see any code in this PR which actually adds the prefixes - only the updates to the models to indicate which fields need prefixes. |
Contributor
Author
|
Sorry, fixed! :) |
Member
|
This is great. I added some more details in the readme, some tests and made a few adjustments to how prefixes get added on import. Check out the latest master branch to see this in action. Could you review the changes I made and let me know if this looks good and works for your use case? Then, I'll release it in a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've just coded the prefix funcionality. As there may be collisions of IDs when importing multiple feeds, a prefix may be declared to omit ambiguity. Then all merges ideally. I've run linter, but tests failed to start with my npm. Please, check all the changes and enjoy! :)