Skip to content

fix(abstract-utxo): pass Zcash recovery block height - #9683

Merged
abhi-bitgo merged 1 commit into
masterfrom
fix/sc-7552-zec-recovery-height
Sep 10, 2026
Merged

fix(abstract-utxo): pass Zcash recovery block height#9683
abhi-bitgo merged 1 commit into
masterfrom
fix/sc-7552-zec-recovery-height

Conversation

@ralph-bitgo

@ralph-bitgo ralph-bitgo Bot commented Sep 8, 2026

Copy link
Copy Markdown

What

  • Add optional blockHeight to RecoverParams and the pre-derived recovery parameters.
  • Thread the value through backup-key recovery into Zcash PSBT construction.
  • Verify a post-NU6.2 height selects branch ID 0x5437f330.

Why

Non-BitGo ZEC recoveries omitted a current height and used the stale NU6.1 fallback, causing transactions to be rejected by NU6.2 nodes.

Verification

  • yarn workspace @bitgo/abstract-utxo build
  • BITGOJS_TEST_PASSWORD=test-password yarn workspace @bitgo/abstract-utxo unit-test --grep "uses the supplied post-NU6.2 block height"

Ticket: SC-7552

@linear-code

linear-code Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

SC-7552

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@ralph-bitgo
ralph-bitgo Bot force-pushed the fix/sc-7552-zec-recovery-height branch from 52e913c to 2975e82 Compare September 10, 2026 04:00
Add blockHeight to public recovery parameters and thread it into the Zcash PSBT builder.

Cover the NU6.2 branch ID at the activation height so non-BitGo ZEC recovery callers can
supply an independent current height instead of using the stale NU6.1 branch ID.

Ticket: SC-7552
Session-Id: f94964a3-36f2-408a-8e36-9d4dc606220b
Task-Id: 726038f1-9cab-4db1-9198-faec874137e8
@abhi-bitgo
abhi-bitgo force-pushed the fix/sc-7552-zec-recovery-height branch from 2975e82 to 65bf651 Compare September 10, 2026 05:19
@abhi-bitgo
abhi-bitgo marked this pull request as ready for review September 10, 2026 06:19
@abhi-bitgo
abhi-bitgo requested a review from a team as a code owner September 10, 2026 06:19
@abhi-bitgo
abhi-bitgo force-pushed the fix/sc-7552-zec-recovery-height branch 2 times, most recently from ebe1205 to 65bf651 Compare September 10, 2026 06:21
@abhi-bitgo
abhi-bitgo self-requested a review September 10, 2026 06:25
@abhi-bitgo
abhi-bitgo merged commit b1b10b3 into master Sep 10, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants