chore: remove test_package_updates.yml workflow #6394
Merged
+0
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job is failing somewhat randomly on PRs where the code change is not actually causing the failure. The `test_package_updates.yml` workflow is not providing much value: - The result is mostly determined by external factors like new package versions appearing on `npmjs.com`, not by the code changes in the PR. This is a frustrating experience for developers. - The workflow seeks to simulate downstream installs by removing the `yarn.lock` file. However, this is not a realistic simulation. We have a toplevel `package.json` file with quite a long a `resolutions` section that overrides many package versions. Without it, the workflow would fail. Downstream projects do not take these resolutions into account, so the `yarn.lock` removal is a bit pointless. If there are downstream problems due to incorrect package versions, they have to submit a bug report instead. Let's get rid of this workflow. Issue: BTC-2170
saravanan7mani
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_package_updates.ymlworkflow is being removed because it's failingrandomly on PRs where the code change is not actually causing the failure.
This workflow doesn't provide much value for the following reasons:
npmjs.com) rather than code changes in the PR, creating a frustrating
developer experience
yarn.lockisn'trealistic, since our toplevel
package.jsonhas an extensiveresolutionssection that overrides many package versionsyarn.lockremoval pointless
bugs anyway
BTC-2170