Port antiklepto test #1662
Merged
Port antiklepto test #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
reviewed
Nov 2, 2025
| // tested in test_keystore_antiklepto.c. That the host nonce was included in the sig is | ||
| // tested by the siganture fixture test below.x | ||
| // tested in keystore::tests::test_secp256k1_antiklepto_protocol. That the host nonce was included in the sig is | ||
| // tested by the siganture fixture test below. |
There was a problem hiding this comment.
Fixed :D The same typo also exists in secp256k1-zpk (probably also added by me 🙈 ) and one in secp256k1-sys crate haha.
Somehow not caught by CI before.
It's always NULL.
benma
force-pushed
the
port-antiklepto-test
branch
from
2999b62 to
74c7256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.