ble: Wait with setting the product string to after orientation #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
nickez/ble-product-after-orientation
branch
6 times, most recently
from
f106e2e to
3341d06
Compare
benma
added a commit
to benma/bitbox-wallet-app
that referenced
this pull request
May 12, 2025
Before BitBoxSwiss/bitbox02-firmware#1447, the product characteristic version string didn't include a 'v' prefix, but after it does. The app backend requires it to parse the version. We handle both cases for backwards compatibility.
NickeZ
force-pushed
the
nickez/ble-product-after-orientation
branch
2 times, most recently
from
1a5e142 to
8e24f8c
Compare
usb_processing wasn't being setup until AFTER usb was enabled. This was a problem beacuse the app is so fast that it manages to send the first requests over ble before usb is setup. Since "usb_processing" is unrelated to the usb driver, we initialize it before we initialize the usb driver.
NickeZ
force-pushed
the
nickez/ble-product-after-orientation
branch
from
8e24f8c to
1051dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.