Skip to content

qt: persist local storage #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

qt: persist local storage #3340

merged 1 commit into from
May 14, 2025

Conversation

benma
Copy link
Contributor

@benma benma commented May 9, 2025

In Qt 5 this was on by default, but since our upgrade to Qt 6 this broke, as in Qt 6 one has to explicitly set the persistent storage path.

When we upgraded from Qt 5.15 to Qt 6, the default profile seemed to
have changed from being stored on disk to off-the-record:

- https://doc.qt.io/qt-5/qwebengineprofile.html#defaultProfile
- https://doc.qt.io/qt-6.5/qwebengineprofile.html#defaultProfile

This made the third party widgets (MoonPay, Pocket, ...) lose their
cookies/localstorage upon app restart.

This commit switches our profile to be stored on disk once more. We
choose a new storage name "BitBoxApp" (not "Default" which was used
previously) to not run into potential conflicts or very old
user sessions that get unexpectedly resumed.
@benma benma force-pushed the qt-localstorage branch from f8773bd to 00d7607 Compare May 13, 2025 14:57
@benma benma requested a review from thisconnect May 13, 2025 14:57
Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

tested thisconnect@92266ae

@benma benma merged commit 81a30e9 into BitBoxSwiss:master May 14, 2025
10 checks passed
@benma benma deleted the qt-localstorage branch May 14, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants