-
Notifications
You must be signed in to change notification settings - Fork 101
update notes import and export file type to jsonl #3301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update notes import and export file type to jsonl #3301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this also needs to be extended:
Lines 356 to 358 in 1e5ec74
// import notes form uses .txt file type, but is not supported here. | |
if (".txt".equals(mimeTypes[0])) { | |
fileType = "text/plain"; |
880cd7a
to
a6d1b3e
Compare
@benma PTAL, change assumes that getAcceptTypes() returns two elements (Kept the existing check to map to a single valid type) |
tested a6d1b3e on Android. Importing |
d840753
to
27486cc
Compare
The (android) filer picker shows |
Changes the file type of notes exports to .jsonl (JSON Lines), which is a more common format used by compatible wallets as specified in BIP-329. For example, exporting labels with Sparrow Wallet creates a .jsonl, which would previously have to be renamed manually in order to allow importing it in the BitBoxApp. The supported import file types are updated accordingly, still allowing .txt imports for exports created prior to this change.
27486cc
to
e690423
Compare
rebased, sry forgot to re-request review |
It would be still very nice to have the filter-by-file-type so that it only shows supported files (.txt and .jsonl). |
Changes the file type of notes exports to .jsonl (JSON Lines), which is a more common format used by compatible wallets as specified in BIP-329.
For example, exporting labels with Sparrow Wallet creates a .jsonl, which would previously have to be renamed manually in order to allow importing it in the BitBoxApp.
The supported import file types are updated accordingly, still allowing .txt imports for exports created prior to this change.