Skip to content

frontend/add-account: ask user to connect BitBox02 to continue #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

benma
Copy link
Contributor

@benma benma commented Nov 30, 2023

Since watchonly, one can enter this screen without a keystore connected. If so, we ask the user to connect to proceed.

@benma benma requested a review from shonsirsha November 30, 2023 08:29
@thisconnect thisconnect removed the request for review from shonsirsha November 30, 2023 09:01
Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM with suggestion

return (
<div className="text-center">
{t('connectKeystore.promptNoName')}
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff --git a/frontends/web/src/routes/account/add/add.tsx b/frontends/web/src/routes/account/add/add.tsx
index a97d87496..62a4735b2 100644
--- a/frontends/web/src/routes/account/add/add.tsx
+++ b/frontends/web/src/routes/account/add/add.tsx
@@ -130,9 +130,9 @@ export const AddAccount = () => {
     case 'select-coin':
       if (supportedCoins.length === 0) {
         return (
-          <div className="text-center">
+          <Message type="info">
             {t('connectKeystore.promptNoName')}
-          </div>
+          </Message>
         );
       }
       return (

So it looks a bit more prominent:

Screen Shot 2023-11-30 at 10 08 19

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

Since watchonly, one can enter this screen without a keystore
connected. If so, we ask the user to connect to proceed.
@benma benma merged commit 240c6a9 into BitBoxSwiss:staging-watchonly Nov 30, 2023
@benma benma deleted the addaccount branch November 30, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants