Diffuse types - #18
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 93.13% 93.34% +0.20%
==========================================
Files 5 5
Lines 685 691 +6
==========================================
+ Hits 638 645 +7
+ Misses 47 46 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrke
approved these changes
Mar 30, 2026
| diffuse_irradiance(diffuse_model, n, λτR, buffers, cz, intcz, Sλ_n, ar², m_Zₐ, albedo, z, FD, FDQ, s̄) | ||
|
|
||
| Calculate diffuse (scattered) spectral irradiance for a single wavelength. | ||
| Dispatches on `diffuse_model` to select the scattering algorithm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are very important choses for model performance - scattered_uv totally dominates run time costs.
This PR makes it much more explicit which Diffuse UV model we are using.
It will break downstream packages like Microclimate.jl