Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/filter #41

Merged
merged 3 commits into from
Feb 23, 2016
Merged

Feature/filter #41

merged 3 commits into from
Feb 23, 2016

Conversation

Varal7
Copy link
Member

@Varal7 Varal7 commented Feb 21, 2016

No description provided.

e.g :
http://localhost:8000/api/transaction/?debited_account=71 should return
the transactions where account_id 71 has been debited
@Ekleog
Copy link
Member

Ekleog commented Feb 23, 2016

Hmmm, untested yet, mais les tests travis passent avant 94ad7b4 ; donc il est vraiment nécessaire ?

Sinon, same as #40 : manquent des tests mais sinon LGTM, on peut merger s'il y a nécessité pour avancer par ailleurs :)

@Varal7
Copy link
Member Author

Varal7 commented Feb 23, 2016

Il manque effectivement des tests. En revanche, j'ai besoin de ça pour avancer sur le khube.
Le fichier requirements, c'est pour que pip3 install -r requirements.txt installe django-filter s'il n'est pas installé.

@Ekleog
Copy link
Member

Ekleog commented Feb 23, 2016

Je viens de tester, OK pour merger quand tu veux

Varal7 added a commit that referenced this pull request Feb 23, 2016
@Varal7 Varal7 merged commit 7d00f17 into develop Feb 23, 2016
@Varal7 Varal7 deleted the feature/filter branch February 23, 2016 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants