Skip to content

Fixed onWillPop assert error#309

Open
yu1ro wants to merge 1 commit into
BilalShahid13:masterfrom
yu1ro:patch-1
Open

Fixed onWillPop assert error#309
yu1ro wants to merge 1 commit into
BilalShahid13:masterfrom
yu1ro:patch-1

Conversation

@yu1ro

@yu1ro yu1ro commented Oct 9, 2022

Copy link
Copy Markdown

fix #308

@ayoubm

ayoubm commented Oct 10, 2022

Copy link
Copy Markdown

@BilalShahid13 can you please merge this PR? It's needed for the willPopScope to work properly.

Thank you!

@pishguy

pishguy commented Nov 9, 2022

Copy link
Copy Markdown

@yu1ro +1

@htunlin-kitesense

Copy link
Copy Markdown

Hello, can help merge this PR? willPopScope not working properly in PersistentTabView.custom.

@danielcabral-code

Copy link
Copy Markdown

Hey, would be nice if someone could merge this please. As @htunlin-kitesense mentioned, PersistentTabView.custom is currently impossible to use.

@AndreSait

AndreSait commented Apr 26, 2023

Copy link
Copy Markdown

In flutter 3.7.8, the onWillPop creates some casting problems, which can be fixed by changing it to this:

onWillPop: !widget.handleAndroidBackButtonPress && widget.onWillPop != null ? () async { final result = await widget.onWillPop!(_contextList[_controller!.index]); return Future.value(result); }

@pupubird

pupubird commented Jul 6, 2023

Copy link
Copy Markdown

Please help to merge this PR :c

@pupubird

Copy link
Copy Markdown

For anyone ever come to this issue, here's the V2 that's actively maintained https://pub.dev/packages/persistent_bottom_nav_bar_v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

onWillPop is not working properly

8 participants