Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with_bind_socket method to return ClientConfigBuilder instead of ServerConfigBuilder #249

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Update with_bind_socket method to return ClientConfigBuilder instead of ServerConfigBuilder #249

merged 1 commit into from
Jan 26, 2025

Conversation

awnion
Copy link
Contributor

@awnion awnion commented Jan 25, 2025

fixes #248

@BiagioFesta
Copy link
Owner

Thank you! :)

@BiagioFesta
Copy link
Owner

Can you please force a rebase?

@BiagioFesta BiagioFesta merged commit 8f2926c into BiagioFesta:master Jan 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiagioFesta BiagioFesta BiagioFesta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong return type for with_bind_socket in case of ClientConfigBuilder
2 participants
@awnion @BiagioFesta