-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .devenv to projectRootsSearchExclude.default
array
#2643
base: dev
Are you sure you want to change the base?
add .devenv to projectRootsSearchExclude.default
array
#2643
Conversation
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
projectRootsSearchExclude.default
array
e6ff645
to
3e450a8
Compare
Thanks for helping with making Calva better! 🙏 The change looks fine. I have added a small suggestion for CHANGELOG wording. We do not merge changes that the author hasn't tested. I am assuming you have tested it, and are reading the checklist item as meaning “added automated tests”, which is not what it is about. Please confirm that you have tested the change. Also for the formatting and linting, we appreciate that this is confirmed. If you are running the build task, these two things are taken care of, and you can check the outputs of the task to confirm. If you are not running the build task, you can check here for the PR build. It is tested in CI, so if CI says the build is cool, the formatting and linting passes: https://app.circleci.com/pipelines/github/BetterThanTomorrow/calva |
Co-authored-by: Peter Strömberg <[email protected]>
I ran I also ran As you mentioned in issue #2642 (comment), one could simply declare "calva.projectRootsSearchExclude": [
".cpcache",
".devenv",
".git",
".vscode"
] I haven't yet tested it on my local version of Calva though. I have just started reading how to run Calva in development mode. |
I have just realized that in [
"bower_components",
".bzr",
".cache",
".ccls-cache",
".clangd",
".classpath",
"*.code-search",
".cpcache",
"_darcs",
".devenv",
".DS_Store",
".ensime_cache",
".eunit",
"flow-typed",
"_FOSSIL_",
".fslckout",
".git",
".hg",
".idea",
".joyride",
"node_modules",
".pijul",
".project",
".shadow-cljs",
".stack-work",
".svn",
"target",
".tox",
".vscode"
] We could run a small shell script or Babashka script before running cat package.json | jq '.contributes.configuration[0].properties."calva.projectRootsSearchExclude".default' > docs/site/projectRootsSearchExclude.json |
Good point. It is better to remove the image, I think. I can do that later. |
Cool. Holler when you've gotten that tested and we'll be merging this. Thanks again for the help with this! |
@jackdbd did you ever get to test this in your local dev env? |
What has changed?
This PR proposes a solution to the problem described in #2642 .
I just added
.devenv
to theprojectRootsSearchExclude.default
array.Fixes #2642
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.npm run prettier-format
)~npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).~Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik