Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2592 win jack in take one trillion #2593

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Jul 3, 2024

What has changed?

On Windows:

  • Explicitly using cmd.exe as the process shell (using no shell wasn't reliable across machines it seems)
  • Using the bundled deps.clj.jar (regardless if clojure has been confirmed as installed, because we need it to work in cmd.exe)
  • Changing the quoting of strings to be for cmd.exe, because different Powershell version treat this differently.
  • Added info to the confirming message box about that the command may only work in cmd.exe.

So, with some luck:

(But we will see, I guess...)

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested a review from bpringe July 3, 2024 19:49
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 8cf1e5d
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/6685ab5c66f12e000843e1c4
😎 Deploy Preview https://deploy-preview-2593--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ PEZ merged commit 7d12da4 into dev Jul 3, 2024
4 of 5 checks passed
@PEZ PEZ deleted the 2592-win-jack-in-take-one-trillion branch July 3, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant