WIP: Add webview output experience #2481
Conversation
Refactor
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
package.json
Outdated
| @@ -3254,6 +3254,7 @@ | |||
| "open": "^6.3.0", | |||
| "parinfer": "^3.12.0", | |||
| "posthtml-parser": "^0.11.0", | |||
| "react-dom": "^18.2.0", | |||
There was a problem hiding this comment.
I don't know if we need React for something in particular. If we do, then of course we should use it. Otherwise, it may be better to use something with less bloat, like Dumdom, or maybe Replicant.
There was a problem hiding this comment.
It's for reagent, which I consider very lightweight and should be used lightly for this. If you think there's any performance issue or other issues with it that would be significant for our use-case, we should discuss that, but switching it out later should be pretty simple.
There was a problem hiding this comment.
I'm open to alternatives if there's a good reason to use something else.
There was a problem hiding this comment.
Dumdom looks interesting. Using a library that supports react gives us reach into the react ecosystem though, which could be nice in the future for more rich features and interactivity (making it less likely we'll need to recreate the wheel).
There was a problem hiding this comment.
My experience with React is that it changes all the time in breaking ways, making it high maintenance. With Dumdom we would avoid this, as the vdom library it uses is super tiny and stable. With Replicant we would get a pure ClojureScript vdom as well, and have even more of the familiar Clojure stability (though I am not sure if the Replicant API is marked as stable yet).
However, I am not opposed to React if we have a good reason to use it.
There was a problem hiding this comment.
I say we move forward with it for a first-release, and maybe be conscious of our usage of it (keeping it light), and if we come across issues we can switch it out later.
I'll continue to keep other options in mind and think about the React usage for now...
There was a problem hiding this comment.
I say we move forward with it for a first-release
I may reconsider this. I need to look at Dumdom more closely.
There was a problem hiding this comment.
Having had a closer look at Replicant, In think it's better to use that instead of Dumdom. They are quite similar, but Replicant drops the dependency on Snabbdom, as well as some legacy API requirements that Dumdom carries.
|
Shall we try to release this behind an opt-in setting as quickly as we can? |
Sorry, I'm moving slowly with this so far due to being busy with other life things. It's not quite ready but there's not that much more to do before getting it to a very basic usable state. I've started dedicating a little focused dev time on weekends for this. |
… ui code to use replicant
What has changed?
A new webview for REPL output is added. It will be a new output location in settings. This is still in the exploratory phase (sort of). I'm opening this draft PR now for visibility and also so I can use it quickly gain context again when I pick this work up here and there as I have time. I'm exploring unknowns and potential problem areas before spending much time on stuff we know we can do.
Once this is in a usable state I plan to dogfood is by using it for work for a while before releasing it.
This is also an experiment in adding a new feature almost completely in cljs, which utilizes the VS Code API.
Closes #2480
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik