fix: proxy_base_url on the Proxy UI #11077
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
wagnerjt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| @@ -2,6 +2,7 @@ | |||
| const nextConfig = { | |||
| output: 'export', | |||
| basePath: process.env.UI_BASE_PATH || '/ui', | |||
| baseProxyUrl: process.env.PROXY_BASE_URL || '/', | |||
There was a problem hiding this comment.
hey @wagnerjt could you explain what happens when this value is set on nextconfig?
There was a problem hiding this comment.
since our UI is rendered from the server as static html - how is this change used ?
There was a problem hiding this comment.
During the custom UI build process, nextjs will recognize if this environment variable is set and inject the variable.
Something like RUN UI_BASE_PATH=${UI_BASE_PATH} npm run build.
To be even more dynamic, we could make anl new endpoint on the python server that returns the env variables for the UI on startup. Would this be preferred?
Proxy UI using PROXY_BASE_URL
Relevant issues
Handles #10761
Pre-Submission checklist
Type
🐛 Bug Fix
🧹 Refactoring
Changes
UI Proxy respecting the the
PROXY_BASE_URL.