modify nametag_visibility in arena.yml + fixed teamstats: false when using team #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Overall, looks pretty good, however I'd double check the spacing since it seems there's a few issues there. IntelliJ should be able to resolve this (see: https://www.jetbrains.com/help/idea/reformat-and-rearrange-code.html). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request.
I appreciate your patience and understanding as I navigate this process.
Changes Made:
1.Nametag Visibility Customization
I added the ability to set the nametag_visibility property in arena.yml when using the team_colors module.
This is useful for scenarios where you want to hide other teams' name tags from view.
2.Individual vs. Team Victory Setting
I noticed that even when Teamstats: false was set, all team members were declared as winners. I fixed this issue so that the plugin now correctly supports individual victories.
This makes it easier to configure Free-For-All (FFA) arenas. By setting everyone on the same team, hiding their name tags with nametag_visibility, and enabling friendly fire, FFA setups can be achieved effortlessly.