Rename human_interaction approach and fix Wait crash#33
Merged
Conversation
Pass abstract_function to option_policy_to_policy so Wait can use the atom-change termination in utils.py without tripping the assertion. Without it, selecting Wait crashes on the second step of the option. Also rename the approach to mirror human_low_level_control: - File: human_interaction_approach.py -> human_option_control_approach.py - Class: HumanInteractionApproach -> HumanOptionControlApproach - Flag: --approach human_interaction -> --approach human_option_control - CFG: human_interaction_approach_* -> human_option_control_approach_* Cross-references updated in human_low_level_control's docstring, the skill-factories integration test, and the predicatorv3 YAML configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abstract_functiontooption_policy_to_policyfrom the human-in-the-loop approach so selectingWaitdoesn't trip the assertion atutils.py:1763and the option can run until the abstract atoms change.human_low_level_control_approach:human_interaction_approach.py→human_option_control_approach.pyHumanInteractionApproach→HumanOptionControlApproach--approach human_interaction→--approach human_option_controlhuman_interaction_approach_*→human_option_control_approach_*human_low_level_control_approach.pydocstring,tests/test_skill_factories_integration.py, and thepredicatorv3YAML configs.