Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean grunt completion #2136

Closed
wants to merge 2 commits into from
Closed

Clean grunt completion #2136

wants to merge 2 commits into from

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Mar 15, 2022

Description

Simplify the completion file with evaluation of grunt --completion=bash and fixed linting

Motivation and Context

Help clean bashit #1696

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@tbhaxor tbhaxor mentioned this pull request Mar 15, 2022
Closed
8 tasks
NoahGorny
NoahGorny reviewed May 18, 2022
View reviewed changes
completion/available/grunt.completion.bash

complete -o default -F _grunt_completions grunt
if _command_exists grunt; then
eval "$(grunt --completion=bash)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get "Specified grunt shell completion rules for bash not found"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange. I just tried and it is working.

Copy link
Contributor Author

@tbhaxor tbhaxor May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you on macOS or Linux?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also tested grunt with gulp both are working on my end.

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Feb 23, 2023

Timeout

@tbhaxor tbhaxor closed this Feb 23, 2023
@tbhaxor tbhaxor deleted the improve/grunt-completion branch February 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbhaxor @NoahGorny