Skip to content

Conversation

@YOUR-WORST-TACO
Copy link
Contributor

Description

Added needed fan speeds for a script I am writing, while testing found that the gcode execution was not functioning.

This PR seeks to solve the following issues:

  • gcode codes not functioning properly
  • add fan speed getters for part, auxiliary and chamber fans

@ohmdelta
Copy link
Collaborator

What printer and firmware version are u using

@YOUR-WORST-TACO
Copy link
Contributor Author

X1C on 01.08.05.00

@ohmdelta
Copy link
Collaborator

Ok there's been a few changes to the firmware and the mqtt contract seems to have changed. We're probably not going to officially support 1.08 given the firmware lockdown. Think your changes are fine for older versions, will do some testing

@YOUR-WORST-TACO
Copy link
Contributor Author

Does that support end at 1.08.05 or 1.08.02?

@ohmdelta ohmdelta requested a review from mchrisgm March 21, 2025 19:43
Copy link
Collaborator

@ohmdelta ohmdelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ohmdelta
Copy link
Collaborator

Does that support end at 1.08.05 or 1.08.02?

as of right now we don't plan to support 1.08 officially, since it's like that firmware wont be allowed to be rolled back. It's likely a LAN mode in 1.08 might still work somewhat with this api. It does look unlikely that future firmware versions will be as open to interface with as 1.06 and below.

We're actually currently working through which firmware versions support certain functionalities - seems like M104 and M140 gcode via mqtt has been disabled since 1.07 for instance

@ohmdelta ohmdelta merged commit 7936135 into BambuTools:main Mar 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants