chore: refactor-R1 #17
Conversation
Bad3r
commented
Oct 26, 2025
Bad3r
commented
- feat(taxonomy): add phase0 guardrails and metadata
- fix(ci): scope checks under per-system outputs
- docs(rfc-0001): note per-system phase0 checks
- chore(phase0): land guardrail baseline
- docs(taxonomy): land phase0 documentation scaffolding
- chore(rfc-0001): finalize canonical taxonomy rollout
- feat(profiles): export workstation namespace and refresh docs
- docs(parity): record phase2 baseline and manifest deltas
- chore(phase2): fix role extenders and refresh manifest
- chore(rfc-0001): finalize phase3 workstation cutover
- feat(rfc-0001): add phase4 workstation parity check
- docs(rfc-0001): refresh canonical profile guidance
- docs: add RFC-0001 release notes
- docs(taxonomy): record versioning, tags, and profiles
- fix(roles): ensure role extras augment canonical modules
- test(roles): guard roleExtras by asserting nix-ld import
- feat(system76): wire duplicati and refresh workstation manifest
- fix(ci): seed roleExtras when evaluating roles
- chore(secrets): tune duplicati bankdata job
- chore: update docs
- docs: add summary of issue
- fix: remove needs to for secrets
- chore: wip
- Revert "chore: wip"
- chore: to discard
- add role import reporter and metadata lint wiring - wire all phase0 checks into flake checks and taxonomy helpers Validation: - nix build .#checks.x86_64-linux.phase0-host-package-guard --accept-flake-config (fails as expected) - nix build .#checks.x86_64-linux.phase0-profile-purity --accept-flake-config (fails as expected) - nix build .#checks.x86_64-linux.phase0-alias-registry --accept-flake-config (fails as expected) - nix build .#checks.x86_64-linux.phase0-taxonomy-version --accept-flake-config (fails as expected) - nix build .#checks.x86_64-linux.phase0-metadata --accept-flake-config (fails as expected) - nix build .#checks.x86_64-linux.phase0-role-imports --accept-flake-config (fails as expected)
- nix flake check --accept-flake-config
This reverts commit 4d397e6.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sharedBaseModulesWithoutTrace = lib.unique ( | ||
| [ | ||
| inputs.sops-nix.homeManagerModules.sops | ||
| ({ osConfig, ... }: | ||
| { | ||
| home.stateVersion = osConfig.system.stateVersion; | ||
| accounts = { | ||
| calendar.basePath = lib.mkDefault ".local/share/calendars"; | ||
| contact.basePath = lib.mkDefault ".local/share/contacts"; | ||
| }; | ||
| } | ||
| ) | ||
| requiredBase | ||
| ] | ||
| ++ lib.optional (hmModules ? r2Secrets) (lib.getAttr "r2Secrets" hmModules) | ||
| ++ lib.optional (hmModules ? context7Secrets) (lib.getAttr "context7Secrets" hmModules) | ||
| ); |
There was a problem hiding this comment.
The new Home Manager wiring builds sharedBaseModulesWithoutTrace via lib.unique. That helper relies on equality comparisons and will throw when any element is a function, because functions are not comparable in Nix. This list includes a lambda (the osConfig module) and optional lambdas from hmModules, so evaluating the module now raises “function is not allowed in a set equality comparison” before anything can run. Drop lib.unique or deduplicate in a way that does not compare functions to avoid breaking every configuration that imports this module.
Useful? React with 👍 / 👎.
