Autocomplete Docs Review #437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-excelsior
reviewed
Apr 5, 2023
v-excelsior
reviewed
Apr 5, 2023
v-excelsior
suggested changes
Apr 6, 2023
Comment on lines
+9
to
+13
| All options are stored in a JSON object, that can be set either by using UI-Builder settings or Codeless Logic. You can also group options by passing a list containing JSON objects to the component: | ||
|
|
||
| <p align="center"> | ||
| <img src="./example-images/autocomplete_component_1.png" alt="Array of objects" width="780"/> | ||
| </p> |
There was a problem hiding this comment.
Move it to example section.
Also will be good to change image of JSON for real text JSON hidden under spoiler.
| <img src="./example-images/autocomplete_component_1.png" alt="Array of objects" width="780"/> | ||
| </p> | ||
|
|
||
| Once the option is selected from the list it gets saved to the local variable **Input Value** in the Codeless Logic. Suppose you selected the "Basketball" option from the list in the e-commerce store, then this value can be used later on to load and display products of a specific category ("Basketball") on the page. You must use the **On Changed Event** handler to get the selected value. |
There was a problem hiding this comment.
local variable Input Value
It's not completely correct. Better to say something like: we could access changed value from input value context codeless block
| <img src="./example-images/autocomplete_component_1.png" alt="Array of objects" width="780"/> | ||
| </p> | ||
|
|
||
| Once the option is selected from the list it gets saved to the local variable **Input Value** in the Codeless Logic. Suppose you selected the "Basketball" option from the list in the e-commerce store, then this value can be used later on to load and display products of a specific category ("Basketball") on the page. You must use the **On Changed Event** handler to get the selected value. |
There was a problem hiding this comment.
Suppose you selected the "Basketball"
Better to use options that we already use before(months from another example).
| <img src="./example-images/autocomplete_component_1.png" alt="Array of objects" width="780"/> | ||
| </p> | ||
|
|
||
| Once the option is selected from the list it gets saved to the local variable **Input Value** in the Codeless Logic. Suppose you selected the "Basketball" option from the list in the e-commerce store, then this value can be used later on to load and display products of a specific category ("Basketball") on the page. You must use the **On Changed Event** handler to get the selected value. |
There was a problem hiding this comment.
You must use the On Changed Event
Typo - Changed -> Change
Comment on lines
+17
to
+19
| <p align="center"> | ||
| <img src="./example-images/autocomplete_component_2.png" alt="On Changed Handler" width="780"/> | ||
| </p> |
There was a problem hiding this comment.
I'm not completely sure if this image is useful. But if you think so, we should change width property(or remove it) in markdown. For now it looks not pretty good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.