fix: exclude tests from build and update node requirement #2
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
jkyberneees
November 18, 2025 19:07
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two technical issues: excluding test files from the TypeScript build process and updating the minimum Node.js version requirement to accurately reflect the features used by the library.
- Added
**/*.test.tspattern to tsconfig.build.json exclude list to prevent test files insrc/from being included in the build output - Updated minimum Node.js version from 10.4.0+ to 11.0.0+ to reflect the requirement for global TextEncoder support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.build.json | Adds **/*.test.ts to exclude pattern to ensure test files in src/ directory are not compiled into the build output |
| README.md | Updates minimum Node.js version requirement from 10.4.0+ to 11.0.0+ to accurately reflect the need for both BigInt and global TextEncoder support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.