Support for exploded params - self contained patch #1075
Conversation
|
|
||
| import Foundation | ||
| import Backbase | ||
|
|
There was a problem hiding this comment.
You're missing an import statement.
import ClientCommonGen2
There was a problem hiding this comment.
Thanks for reviewing my PR, I added missing import
| case .none: | ||
| break | ||
| case .json: | ||
| modifiedRequest = JSONDataEncoding.encode(modifiedRequest, with: bodyParameters) |
There was a problem hiding this comment.
You can't call theencode function as such since is not static.
| headers.forEach { modifiedRequest.setValue($0.value, forHTTPHeaderField: $0.key) } | ||
| Backbase.authClient().tokens().forEach { modifiedRequest.setValue($0.value, forHTTPHeaderField: $0.key) } | ||
|
|
||
| switch bodyType { |
There was a problem hiding this comment.
This switch statement is missing a default case
| method: String, | ||
| queryParameters: [String: Any]?, | ||
| bodyParameters: [String: Any]?, | ||
| bodyType: BodyType, |
There was a problem hiding this comment.
Which BodyType are you referring to here? If possible add the correct namespace
| } | ||
|
|
||
| // MARK: - RequestBuilder Extension with Custom Encoding | ||
| public extension RequestBuilder { |
There was a problem hiding this comment.
| public extension RequestBuilder { | |
| public extension ClientCommonGen2.RequestBuilder { |
| "{{baseName}}": {{#isContainer}}params.{{paramName}}.{{#isExplode}}exploded{{/isExplode}}{{^isExplode}}commaSeparated{{/isExplode}}{{/isContainer}}{{^isContainer}}{{#isFreeFormObject}}(params.{{paramName}} as{{^required}}?{{/required}} String){{^required}}?{{/required}}.encodeToJSON(){{/isFreeFormObject}}{{^isFreeFormObject}}{{#isEnum}}params.{{paramName}}{{^required}}?{{/required}}.rawValue{{/isEnum}}{{^isEnum}}params.{{paramName}}{{^required}}?{{/required}}.{{#isDateTime}}encodeToJSONDateTime{{/isDateTime}}{{^isDateTime}}encodeToJSON{{/isDateTime}}(){{/isEnum}}{{/isFreeFormObject}}{{/isContainer}} |
There was a problem hiding this comment.
Add a check for {{^required}}?{{/required}} to cater for optional parameters
| } | ||
|
|
||
| // Helper extensions for easier ArrayParam creation | ||
| public extension Array { |
There was a problem hiding this comment.
There's need to handle dictionaries as well.
|
Create self contained patch to add support for exploded parameters for GET requests based on OpenAPI exploded property, default is exploded true, like defined in OpenAPI specification.