Skip to content

More robust Validation Tests #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 1, 2025
Merged

More robust Validation Tests #1487

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a65f9fe
More robust Validation Tests
CedricGuillemet Mar 25, 2025
1c3590f
check RT with executeWhenReady
CedricGuillemet Mar 25, 2025
dcf9da1
Clear framebuffer
CedricGuillemet Mar 26, 2025
ba623ca
revert scissor test PG
CedricGuillemet Mar 26, 2025
1370727
0 for depth as well
CedricGuillemet Mar 26, 2025
06d5b11
init RT with 0s
CedricGuillemet Mar 31, 2025
aa27d5b
use bx::memSet
CedricGuillemet Mar 31, 2025
0bb6363
code style
CedricGuillemet Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Apps/Playground/Scripts/validation_native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
done(false);
}
});
});
}, true);
}

function loadPlayground(test, done, referenceImage, compareFunction) {
Expand Down
5 changes: 5 additions & 0 deletions Plugins/NativeEngine/Source/NativeEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1859,6 +1859,8 @@ namespace Babylon
const auto depthStencilFormat{generateStencilBuffer ? bgfx::TextureFormat::D24S8 : bgfx::TextureFormat::D32};
#endif
assert(bgfx::isTextureValid(0, false, 1, depthStencilFormat, flags));
// _mem is NULL so content of the texture is uninitialized.
// framebuffer is cleared to be consistent with browsers.
depthStencilTextureHandle = bgfx::createTexture2D(width, height, false, 1, depthStencilFormat, flags);

// bgfx doesn't add flag D3D11_RESOURCE_MISC_GENERATE_MIPS for depth textures (missing that flag will crash D3D with resolving)
Expand All @@ -1880,6 +1882,9 @@ namespace Babylon
}

Graphics::FrameBuffer* frameBuffer = new Graphics::FrameBuffer(m_deviceContext, frameBufferHandle, width, height, false, generateDepth, generateStencilBuffer);
// Clear framebuffer : https://registry.khronos.org/webgl/specs/latest/1.0/#TEXIMAGE2D
auto encoder = GetUpdateToken().GetEncoder();
frameBuffer->Clear(*encoder, BGFX_CLEAR_COLOR | BGFX_CLEAR_DEPTH | BGFX_CLEAR_STENCIL, 0, 0.0f, 0);
return Napi::Pointer<Graphics::FrameBuffer>::Create(info.Env(), frameBuffer, [frameBuffer, depthStencilTextureHandle]() {
if (bgfx::isValid(depthStencilTextureHandle))
{
Expand Down
Loading