Skip to content

Commit

Permalink
chiron: Move dexpreopt flags to product makefile
Browse files Browse the repository at this point in the history
It's not a right way to patch core/product.mk for readonly variables exception.

Change-Id: Ic6fce0422be4852899c2fc91e12852832572aee2
  • Loading branch information
BYZYB committed Sep 22, 2024
1 parent d46e50a commit 9db6c05
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 25 deletions.
7 changes: 0 additions & 7 deletions BoardConfig.mk
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,7 @@ BOARD_SUPPORTS_SOUND_TRIGGER := true
BOARD_USES_ALSA_AUDIO := true

# Dexpreopt
# [NOTE] This section might assign to readonly variable of Android build system.
# [NOTE] Please keep only WITH_DEXPREOPT_DEBUG_INFO then remove others, if no patch (repo_XX.diff) is applied.
LOCAL_DEX_PREOPT := true
PRODUCT_DEX_PREOPT_DEFAULT_COMPILER_FILTER := everything
PRODUCT_DEX_PREOPT_DEFAULT_FLAGS := --compiler-filter=everything
PRODUCT_OTHER_JAVA_DEBUG_INFO := false
PRODUCT_SYSTEM_SERVER_COMPILER_FILTER := everything
PRODUCT_SYSTEM_SERVER_DEBUG_INFO := false
USE_DEX2OAT_DEBUG := false
WITH_DEXPREOPT_DEBUG_INFO := false

Expand Down
7 changes: 7 additions & 0 deletions device.mk
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ PRODUCT_COPY_FILES += \
# DebugFS
PRODUCT_SET_DEBUGFS_RESTRICTIONS := true

# Dexpreopt
PRODUCT_DEX_PREOPT_DEFAULT_COMPILER_FILTER := everything
PRODUCT_DEX_PREOPT_DEFAULT_FLAGS := --compiler-filter=everything
PRODUCT_OTHER_JAVA_DEBUG_INFO := false
PRODUCT_SYSTEM_SERVER_COMPILER_FILTER := everything
PRODUCT_SYSTEM_SERVER_DEBUG_INFO := false

# Display
PRODUCT_PACKAGES += \
[email protected]:64 \
Expand Down
18 changes: 0 additions & 18 deletions repo_21.diff
Original file line number Diff line number Diff line change
Expand Up @@ -26,24 +26,6 @@ index 5fbc916..a68057d 100644
endif
endif

diff --git a/core/product.mk b/core/product.mk
index 0411fe2..be10e7e 100644
--- a/core/product.mk
+++ b/core/product.mk
@@ -574,7 +574,12 @@ _readonly_late_variables += \
PRODUCT_COPY_FILES \
PRODUCT_DEX_PREOPT_NEVER_ALLOW_STRIPPING \
PRODUCT_DEX_PREOPT_BOOT_FLAGS \
- PRODUCT_SOONG_NAMESPACES
+ PRODUCT_SOONG_NAMESPACES \
+ PRODUCT_DEX_PREOPT_DEFAULT_COMPILER_FILTER \
+ PRODUCT_DEX_PREOPT_DEFAULT_FLAGS \
+ PRODUCT_OTHER_JAVA_DEBUG_INFO \
+ PRODUCT_SYSTEM_SERVER_COMPILER_FILTER \
+ PRODUCT_SYSTEM_SERVER_DEBUG_INFO

_readonly_early_variables := $(filter-out $(_readonly_late_variables),$(_product_var_list))

diff --git a/core/sysprop.mk b/core/sysprop.mk
index 0fcc92c..7bf2989 100644
--- a/core/sysprop.mk
Expand Down

0 comments on commit 9db6c05

Please sign in to comment.