conf: Add Pylint to CI.

.github/workflows/ci.yml

@@ -7,17 +7,28 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+    # Setup
     - name: Checkout code
       uses: actions/checkout@v2
+
     - name: Set up Python
       uses: actions/setup-python@v2
       with:
         python-version: "3.10"
+
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
         pip install -r requirements.txt
-    - name: Lint with black
+
+    # Lint
+    - name: Lint with Black
       run: |
         pip install black
         black --check .
+
+    - name: Lint with Pylint
+      run: |
+        pip install pylint
+        touch __init__.py
+        pylint `pwd` --fail-under=5 --disable=too-few-public-methods,fixme

.gitignore

@@ -1,4 +1,5 @@
 .env
 .idea
 venv
-**__pycache__**
+*.pyc
+__init__.py

README.md

@@ -54,16 +54,10 @@ $ pip install -r requirements.txt
 ```
 Or, if your system contains both Python 2 and Python 3, use `pip3`.
 
-#### 5. Enable Git hooks
-
-```
-$ git config --local --add core.hooksPath .githooks 
-```
-
-#### 6. Get the environment variables from another contributor
-#### 7. [Download and configure ngrok](https://betterprogramming.pub/ngrok-make-your-localhost-accessible-to-anyone-333b99e44b07)
-#### 8. Send your generated URL to MDG org admins
-#### 9. Run the bot
+#### 5. Get the environment variables from another contributor
+#### 6. [Download and configure ngrok](https://betterprogramming.pub/ngrok-make-your-localhost-accessible-to-anyone-333b99e44b07)
+#### 7. Send your generated URL to MDG org admins
+#### 8. Run the bot
 
 ```
 $ python main.py

github_parsers.py

@@ -37,6 +37,7 @@ def parse(event_type, raw_json) -> GitHubEvent:
                     event_type=event_type,
                     json=json,
                 )
+        raise ValueError(f"Undefined event: {raw_json}")
 
 
 # Helper classes:

main.py

@@ -30,10 +30,11 @@ def manage_github_events():
 
 
 @post("/slack/commands")
-def manage_slack_commands():
+def manage_slack_commands() -> Optional[dict]:
     response: Optional[dict] = bot.run(raw_json=request.forms)
     if response is not None:
         return response
+    return None
 
 
 bot: SlackBot = SlackBot()

models/github.py

@@ -71,6 +71,7 @@ def __init__(self, name: str, **kwargs):
         self.link = kwargs.get("link", f"https://github.com/{name}")
 
 
+# pylint: disable-next=too-many-instance-attributes
 class GitHubEvent:
     def __init__(self, event_type: EventType, repo: Repository, **kwargs):
         self.type = event_type