[WIP] JSON Output - #3847
Draft
HassanAbouelela wants to merge 3 commits into
Draft
[WIP] JSON Output#3847HassanAbouelela wants to merge 3 commits into
HassanAbouelela wants to merge 3 commits into
Conversation
Create and add a printer class to output data in either JSON or plain fomrat.
Restructured data print methods to accommodate for JSON and regular output.
Add native unit tests for the pretty printer class. No functional changes.
AenBleidd
marked this pull request as draft
June 17, 2020 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1457
Description of the Change
Created a JSON printing class, and rewrote boinccmd to use it.
Alternate Designs
It is possible to hardcode the JSON output similar to the way the old system was. This method was chosen because it allows more options to be added, without much extra work, and can be used for other data output (See #3726).
Release Notes
Added JSON output options to boinccmd.
Additional Notes
f8b63d0 adds a test suite for the pretty_printer class, but introduces no actual changes.