Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WarpXFluidContainer::InitData : pass parameters as function arguments instead of using static variables of the WarpX class #5787

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

WarpXFluidContainer::InitData : pass parameters as function arguments instead of using static variables of the WarpX class #5787

wants to merge 1 commit into from

Conversation

lucafedeli88
Copy link
Member

This PR changes WarpXFluidContainer::InitData so that all the required parameters are passed as arguments, instead on relying on the static variables of the WarpX class.

@lucafedeli88 lucafedeli88 added component: fluid fluid species cleaning Clean code, improve readability labels Mar 21, 2025
@lucafedeli88 lucafedeli88 changed the title WarpXFluidContainer::InitData : pass parameters by value instead of using static variables of the WarpX class WarpXFluidContainer::InitData : pass parameters as function arguments instead of using static variables of the WarpX class Mar 21, 2025
@RemiLehe RemiLehe requested a review from EZoni March 24, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EZoni EZoni Awaiting requested review from EZoni

At least 1 approving review is required to merge this pull request.

Assignees

@EZoni EZoni

Labels
cleaning Clean code, improve readability component: fluid fluid species
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucafedeli88 @EZoni