Tests: amrex.the_arena_init_size=0
#5785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
backend: cuda
`amrex.the_arena_init_size=0` is default on CPU but not GPU. In order to run tests in parallel on the same GPU, we need to change the default so the first test does not allocate 3/4th of the memory of the GPU (to speed up later allocations in a pre-allocated heap). This currently only applys to app tests, but not yet to the Python CTests. Need to add an extra option for those, because we cannot inject CLI options.
ax3l
force-pushed
the
tests-gpu-zero-initsize
branch
from
369c45e to
a29a4b1
Compare
5 tasks
EZoni
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Thanks, @ax3l. Looks good to me.
@WeiqunZhang
I will wait for your approval and then merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amrex.the_arena_init_size=0is default on CPU but not GPU. In order to run tests in parallel on the same GPU, we need to change the default so the first test does not allocate 3/4th of the memory of the GPU (to speed up later allocations in a re-allocated heap).This currently only applies to app tests, but not yet to the Python CTests. Need to add an extra option for those, because we cannot inject CLI options. This will be a follow-up, because we need to inject a few vars (debugger breaking, init size, warning thresholds) and this might need a WarpX-Python specific test env var or something of that sort.