Skip to content

Conversation

@RemiLehe
Copy link
Member

The recent PR #3255 broke compilation for the RZ code on GPU. (It seems that this was not tested in CI.)

This is due to a check which we already do anyways here:
https://github.com/ECP-WarpX/WarpX/blob/development/Source/Particles/Collision/CollisionHandler.cpp#L35

Therefore, I removed the duplicated check here, in order to fix the compilation on GPU

@RemiLehe RemiLehe requested a review from EZoni September 21, 2022 20:32
@RemiLehe RemiLehe added bug Something isn't working backend: cuda Specific to CUDA execution (GPUs) geometry: RZ axisymmetric 2D and quasi-3D labels Sep 21, 2022
Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Remi!

@EZoni EZoni self-assigned this Sep 21, 2022
@EZoni EZoni merged commit 9aca2a6 into BLAST-WarpX:development Sep 21, 2022
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend: cuda Specific to CUDA execution (GPUs) bug Something isn't working geometry: RZ axisymmetric 2D and quasi-3D

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants