Skip to content

Conversation

@RemiLehe
Copy link
Member

This adds the values of the mass and charge for the following species:

  • neutron
  • deuterium
  • tritium
  • helium3
  • helium4

The mass data is taken from:

In the cases of the isotopes, I subtracted the mass of the electron, and converted to the units of proton mass, using:

M = (M_nist * m_u - m_e) / m_p

where m_u is the atomic mass unit, m_e is the electron mass, m_p is the proton mass.

@RemiLehe RemiLehe requested review from NeilZaim and lucafedeli88 May 31, 2022 19:11
if( species=="proton" )
if( species=="neutron" )
return PhysicalSpecies::neutron;
if( (species=="hydrogen") || (species=="proton") )
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is not very consistent with the way in which we treat "helium".
For consistency, we should distinguish:

  • hydrogen (includes the mass of the electron, averages over isotopes abundance)
  • proton/hydrogen1 (does not include the mass of the electron, does not average over isotopes)
    However, in order to preserve the code behavior, I did not introduce this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Didn't we discuss this for #3090 that @lucafedeli88 has open? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Actually the present PR duplicates #3090. I will close it for now.

@RemiLehe RemiLehe requested a review from ax3l June 1, 2022 16:42
@ax3l ax3l added the component: core Core WarpX functionality label Jun 2, 2022
@RemiLehe RemiLehe closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: core Core WarpX functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants