Regressions: Remove Tolerance #2789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... otherwise we build the `fvarnames` tools automatically.
Member
|
Ok. The changes in PR #2669 were made after I had originally submitted the RZ PSATD PML PR and were not made there. I'll approve. |
roelof-groenewald
added a commit
to ModernElectron/WarpX
that referenced
this pull request
Jan 27, 2022
* remove check on geometry (BLAST-WarpX#2771) * RZ: Add error message when using 0 order for azimuthal decomposition (BLAST-WarpX#2772) * CI: GNUmake (BLAST-WarpX#2769) Since we migrated also Azure regression tests to CMake now, we should add a GNUmake build to CI, so we don't accidentally lose this capability (we will not duplicate the whole CI matrix). Does a standard CUDA build without dependencies but enabling PSATD. * PML Exchanges: Less Duplicate Code (BLAST-WarpX#2394) Similarly to BLAST-WarpX#2375, I'm trying to see if we can reduce the amount of duplicate code, in this case for the functions `Exchange<E,B>` of the PML class. Open for discussion. * AMReX: Update latest (BLAST-WarpX#2773) * Docs: Crusher Load `cce` module (BLAST-WarpX#2770) * Docs: Crusher Load `cce` module Without that module, HIP RDC builds do not work. https://docs.olcf.ornl.gov/systems/crusher_quick_start_guide.html#compilers * cce/13.0.0 -> cce/13.0.1 * Crusher: load `cce` after `rocm` * RZ FDTD: Filter Not Working (Abort) (BLAST-WarpX#2775) * RZ FDTD: Filter Not Working (Abort) * Update CI Tests and Benchmarks * Funding/Acknowledgements: CEA-LIDYL. (BLAST-WarpX#2781) * Update .zenodo.json (BLAST-WarpX#2782) * Add SyncRho call to warpx_depositChargeDensity (BLAST-WarpX#2777) * add SyncRho call to warpx_depositChargeDensity * expose SyncRho to Python; add warpx_clearChargeDensity to reset rho_fp before deposition * remove unneeded warpx_clearChargeDensity function * Apply suggestions from code review Co-authored-by: Axel Huebl <[email protected]> * add (default) option to depositChargeDensity to call SyncRho after deposition * added option to depositChargeDensity to zero out rho_fp before deposition * code cleanup * import fields from inside depositChargeDensity Co-authored-by: Axel Huebl <[email protected]> * udpate zenodo (BLAST-WarpX#2784) Co-authored-by: Hannah Klion <[email protected]> * expose WarpXParticleContainer::sumParticleCharge to Python (BLAST-WarpX#2790) * Add tiny profiling to reduced diagnostics (BLAST-WarpX#2794) * fix typo in docstring for ImpactIonizationTransformFunc constructor (BLAST-WarpX#2793) * style fixes in WarpXWrappers.cpp (BLAST-WarpX#2792) * Regressions: Remove Tolerance (BLAST-WarpX#2789) ... otherwise we build the `fvarnames` tools automatically. * Add Python callbacks before and after collisions (BLAST-WarpX#2791) * add python callbacks before and after collisions * re-order callback declarations * Fix Docs of MinAndMaxPositions (BLAST-WarpX#2787) Fix order of returned tuple (doc string). * Track injection statistics for MCC (#145) * added verbosity flag to MCC * added MCC verbosity flag to mewarpx * expose WarpXParticleContainer::sumParticleCharge to Python * add python callbacks before and after collisions * example of tracking MCC statistics * add MCC injection tracking ability via flux_diagnostic * added MCC to runinfo in diode_setup so that it is added to the flux diagnostic; also updated the thermionic_ignition.py example file to use setups_store * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unneeded call to init_inert_gas in tests using setups_store/diode_setup.py * updated changelog and version number * revert MCC verbosity flag, more info is better than less * avoid MCC injection tracking if it is not used in the simulation * remove duplicated code due to merge * add appropriate date to changelog Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Fedeli <[email protected]> Co-authored-by: Neïl Zaim <[email protected]> Co-authored-by: Axel Huebl <[email protected]> Co-authored-by: Edoardo Zoni <[email protected]> Co-authored-by: Prabhat Kumar <[email protected]> Co-authored-by: Hannah Klion <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... otherwise we build the
fvarnamestools automatically.See #2669
Follow-up to #2211