Generalize Analysis Scripts: Number of Digits (plt) #2683
Conversation
ax3l
force-pushed
the
topic-fileMinPrefix6Prep
branch
from
7a00d75 to
f1c808a
Compare
ax3l
changed the title
Thanks Phil! :) Co-authored-by: Phil Miller <[email protected]>
| import sys | ||
| import yt | ||
| import numpy as np | ||
| import os |
There was a problem hiding this comment.
To be PEP8 compliant, the import os should be before the imports of numpy and yt.
There was a problem hiding this comment.
Interesting PEP8 style choice, because contrary to C/C++ includes, this has no real influence ^^
(besides global behavior, like where mpi4py is placed).
https://www.python.org/dev/peps/pep-0008/#imports
I think we need a bot for this, maybe we can add this to .pre-commit-config.yaml.
I would not change it in the current PR, since already existing sys imports are mostly off. Let's do style fixes to existing code in separate style-only/cleanup PRs?
There was a problem hiding this comment.
Clarified on Slack: separate, we are looking for tools that can do it :)
Maybe autopep8 or flake8.
There was a problem hiding this comment.
I tried autopep8 --select E401,E402 --in-place --aggressive --aggressive <filename> and all it does is sort alphabetically.
There was a problem hiding this comment.
The tool isort does the trick: #2686
https://github.com/PyCQA/isort
4 participants
Preparation for #2385: Generalize a list of test scripts so that we have an easier time finishing that long-standing PR with less conflicts to track.
Also avoids that we add more scripts with the old/hard-coded patterns.