-
Notifications
You must be signed in to change notification settings - Fork 226
CI: Reduce Runtime of Some Galilean Tests #2625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Reduce Runtime of Some Galilean Tests #2625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Olga! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Olga! Looks good to me, we probably just need to reset the checksum benchmarks in averaged_galilean_3d_psatd.json (path: Regression/Checksum/benchmarks_json/).
|
@oshapoval, I see this already improves
can you also check if we can reduce the runtime of:
? :-) |
|
Thank you, Olga! So, here's the new runtimes I'm seeing in the last CI log:
|
|
Have you had the chance to check how the wakefields look like at the final time step of the new test? Some of the benchmark changes are quite large, I'm just curious to see if the wakefield is still well developed or not. I guess it's fine even if it's not as well developed as before, since we're mainly interested in testing regressions here. |
@EZoni Thanks a lot for reviewing this PR! Yes, I did. Wakefield looks good for the CI test. I am attaching the snapshots of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks good to me, I'll merge.
* Modified 'averaged_galilean_3d_psatd' CI test to lower its run time. * Modified 'comoving_2d_psatd_hybrid' CI test to lower its run time. * Modified 'galilean_2d_psatd_hybrid' CI test to lower its run time. * Updated benchmarks.

In this PR, I modified 3D averaged Galilean PSATD regression test for uniform plasma (
averaged_galilean_3d_psatd) in order to lower its run time. In the new test case,dz/dx = 3,cfl=3andmax_step = 160. Reference energy (calculated via standard Galilean PSATD) also was recalculated and changed in/WarpX/Examples/Tests/galilean/analysis_3d.py.