Skip to content

Conversation

@oshapoval
Copy link
Contributor

@oshapoval oshapoval commented Dec 4, 2021

In this PR, I modified 3D averaged Galilean PSATD regression test for uniform plasma (averaged_galilean_3d_psatd) in order to lower its run time. In the new test case, dz/dx = 3, cfl=3 and max_step = 160. Reference energy (calculated via standard Galilean PSATD) also was recalculated and changed in /WarpX/Examples/Tests/galilean/analysis_3d.py.

@oshapoval oshapoval requested review from EZoni and ax3l December 4, 2021 00:40
@ax3l ax3l self-assigned this Dec 4, 2021
@ax3l ax3l added component: spectral Spectral solvers (PSATD, IGF) component: tests Tests and CI labels Dec 4, 2021
@ax3l ax3l assigned EZoni and unassigned ax3l Dec 4, 2021
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Olga! :)

Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Olga! Looks good to me, we probably just need to reset the checksum benchmarks in averaged_galilean_3d_psatd.json (path: Regression/Checksum/benchmarks_json/).

@ax3l
Copy link
Member

ax3l commented Dec 6, 2021

@oshapoval, I see this already improves

  • 80s: averaged_galilean_3d_psatd

can you also check if we can reduce the runtime of:

  • 80s: comoving_2d_psatd_hybrid
  • 83s: galilean_2d_psatd_hybrid

? :-)

@ax3l ax3l mentioned this pull request Dec 6, 2021
8 tasks
@EZoni
Copy link
Member

EZoni commented Dec 14, 2021

Thank you, Olga! So, here's the new runtimes I'm seeing in the last CI log:

  • averaged_galilean_3d_psatd: 33.6 s
  • comoving_2d_psatd_hybrid: 24.9 s
  • galilean_2d_psatd_hybrid: 25.2 s

@EZoni EZoni changed the title Modified 'averaged_galilean_3d_psatd' CI test to lower its run time. CI: Reduce Runtime of Some Galilean Tests Dec 14, 2021
@EZoni
Copy link
Member

EZoni commented Dec 14, 2021

Have you had the chance to check how the wakefields look like at the final time step of the new test? Some of the benchmark changes are quite large, I'm just curious to see if the wakefield is still well developed or not. I guess it's fine even if it's not as well developed as before, since we're mainly interested in testing regressions here.

@oshapoval
Copy link
Contributor Author

Have you had the chance to check how the wakefields look like at the final time step of the new test? Some of the benchmark changes are quite large, I'm just curious to see if the wakefield is still well developed or not. I guess it's fine even if it's not as well developed as before, since we're mainly interested in testing regressions here.

@EZoni Thanks a lot for reviewing this PR! Yes, I did. Wakefield looks good for the CI test. I am attaching the snapshots of the Ez field at timestep step=400 for both 2D Galilean PSATD (hybrid) and comoving PSATD (hybrid). Please see below.
2d_comoving_and_gal_psatd_hybrid

Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good to me, I'll merge.

@EZoni EZoni merged commit 29b846c into BLAST-WarpX:development Dec 16, 2021
lgiacome pushed a commit to lgiacome/WarpX that referenced this pull request Dec 16, 2021
* Modified 'averaged_galilean_3d_psatd' CI test to lower its run time.

* Modified 'comoving_2d_psatd_hybrid' CI test to lower its run time.

* Modified 'galilean_2d_psatd_hybrid' CI test to lower its run time.

* Updated benchmarks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: spectral Spectral solvers (PSATD, IGF) component: tests Tests and CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants