Skip to content

Conversation

@roelof-groenewald
Copy link
Member

If algo.load_balance_costs_update = timers (the default) is used, the cost of MCC will be included in determining tile redistribution.

@roelof-groenewald roelof-groenewald added the component: load balancing Load balancing strategies, optimization etc. label Nov 19, 2021
@ax3l ax3l self-assigned this Nov 19, 2021
@ax3l ax3l requested a review from EZoni November 19, 2021 22:08
@ax3l ax3l added the component: collisions Anything related to particle collisions label Nov 19, 2021
@ax3l
Copy link
Member

ax3l commented Nov 19, 2021

Thanks, splendid!

Do you like to adjust the MCC test case to use the timers instead of the default (heuristics)? That way, we can cover the new functionality in CI.

@roelof-groenewald
Copy link
Member Author

roelof-groenewald commented Nov 19, 2021

Thanks for the suggestion. I will ask @KZhu-ME to update the load balance test, which also uses MCC, (PR #2561) to make sure that timers is used. But it looks like the default is timers, no?
https://github.com/ECP-WarpX/WarpX/blob/a1104408d0752b791622d564e2a6e556b144b1d1/Source/Utils/WarpXAlgorithmSelection.cpp#L69

@ax3l
Copy link
Member

ax3l commented Nov 19, 2021

Oh, you are right! Misremembered https://warpx.readthedocs.io/en/latest/usage/parameters.html

Thx! :)

@ax3l ax3l merged commit 1ab82a3 into BLAST-WarpX:development Nov 19, 2021
@roelof-groenewald roelof-groenewald deleted the rg/mcc_load_balance_cost branch November 22, 2021 17:06
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: collisions Anything related to particle collisions component: load balancing Load balancing strategies, optimization etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants