Skip to content

Conversation

@Yin-YinjianZhao
Copy link
Contributor

This PR mimics the one in PR #2510 to correct the fusion algorithm in RZ.

@RemiLehe
Copy link
Member

@NeilZaim I have added you as a reviewer here, but we could discuss in more detail why this rotation is needed, during the next developer meeting (next Tuesday).
Also: I think that we could discuss whether the second part of the fusion algorithm (the creation of particles with the correct momenta, as implemented in #2330) is already valid for RZ.

@ax3l ax3l added geometry: RZ axisymmetric 2D and quasi-3D component: collisions Anything related to particle collisions labels Nov 16, 2021
@Yin-YinjianZhao Yin-YinjianZhao changed the title Correct fusion algorithm in RZ [WIP] Correct fusion algorithm in RZ Nov 16, 2021
Copy link
Contributor

@NeilZaim NeilZaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Yes, this change sounds reasonable to me if we have a perfect axial symmetry (order 0 RZ). I don't know if modifying the momenta to machine precision is an issue (I guess not) but if we want to avoid that then it's easy to do.

Also, yes we would need to do something similar for the initialization of the product particles (rotate the momentum of one of the colliding particles before and rotate back the momentum of half the produced particles after). I can do that in a follow-up to #2330 if needed.

@RemiLehe
Copy link
Member

This is superseded by #3255

@Yin-YinjianZhao Yin-YinjianZhao deleted the collision_fusion branch September 21, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: collisions Anything related to particle collisions geometry: RZ axisymmetric 2D and quasi-3D

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants