Polygon aperture #1199
Open
Polygon aperture #1199
+646
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Oct 25, 2025
initializer for member object m_id Co-authored-by: Axel Huebl <[email protected]>
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #endif | ||
|
|
||
| // if the aperture is periodic, shift sx,sy coordinates to the fundamental domain | ||
| T_Real u = (m_repeat_x == 0_prt) ? sx : (fmod(abs(sx)+dx, m_repeat_x)-dx); |
Check notice
Code scanning / CodeQL
Equality test on floating-point values Note
|
|
||
| // if the aperture is periodic, shift sx,sy coordinates to the fundamental domain | ||
| T_Real u = (m_repeat_x == 0_prt) ? sx : (fmod(abs(sx)+dx, m_repeat_x)-dx); | ||
| T_Real v = (m_repeat_y == 0_prt) ? sy : (fmod(abs(sy)+dy, m_repeat_y)-dy); |
Check notice
Code scanning / CodeQL
Equality test on floating-point values Note
cemitch99
reviewed
Nov 4, 2025
cemitch99
reviewed
Nov 4, 2025
| * @param action specify action of domain (transmit/absorb) | ||
| * @param vertices_xx array of coordinates of the horizontal vertex positions (m) | ||
| * @param vertices_yy array of coordinates of the vertical vertex positions (m) | ||
| * @param min_radius2 a minimum radius**2 below which all particles are transmitted |
There was a problem hiding this comment.
Suggested change
| * @param min_radius2 a minimum radius**2 below which all particles are transmitted | |
| * @param min_radius2x a minimum radius**2 below which all particles are transmitted |
Doxygen requires that the name in the documentation here coincides with the name of the function argument.
|
I can't seem to do that because I get warnings of shadowed variables.
That's why it is the way it is now. These are the warnings as I changed it
in branch egstern-polygon-apertures-xx.
````
n file included from
/home/egstern/src/impactx-test/src/elements/PolygonAperture.cpp:10:
/home/egstern/src/impactx-test/src/elements/PolygonAperture.H: In
constructor
'impactx::elements::PolygonAperture::PolygonAperture(std::vector<double>,
std::vector<double>, amrex::ParticleReal, amrex::ParticleReal,
amrex::ParticleReal, bool, Action, amrex::ParticleReal,
amrex::ParticleReal, amrex::ParticleReal,
std::optional<std::__cxx11::basic_string<char> >)':
/home/egstern/src/impactx-test/src/elements/PolygonAperture.H:97:33:
warning: declaration of 'min_radius2' shadows a member of
'impactx::elements::PolygonAperture' [-Wshadow]
97 | amrex::ParticleReal min_radius2,
| ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/home/egstern/src/impactx-test/src/elements/PolygonAperture.H:285:29: note:
shadowed declaration is here
285 | amrex::ParticleReal min_radius2; // minimum radius in which
all pass squared
| ^~~~~~~~~~~
/home/egstern/src/impactx-test/src/elements/PolygonAperture.H:96:47:
warning: declaration of 'vertices_y' shadows a member of
'impactx::elements::PolygonAperture' [-Wshadow]
96 | std::vector< amrex::ParticleReal> vertices_y,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/home/egstern/src/impactx-test/src/elements/PolygonAperture.H:284:43: note:
shadowed declaration is here
284 | std::vector< amrex::ParticleReal> vertices_y;
| ^~~~~~~~~~
/home/egstern/src/impactx-test/src/elements/PolygonAperture.H:95:47:
warning: declaration of 'vertices_x' shadows a member of
'impactx::elements::PolygonAperture' [-Wshadow]
95 | std::vector< amrex::ParticleReal> vertices_x,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/home/egstern/src/impactx-test/src/elements/PolygonAperture.H:283:43: note:
shadowed declaration is here
283 | std::vector< amrex::ParticleReal> vertices_x;
| ^~~~~~~~~~
```
…On Tue, Nov 4, 2025 at 2:11 PM Chad Mitchell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/elements/PolygonAperture.H
<#1199 (comment)>
:
> + {
+ transmit,
+ absorb
+ };
+
+ static std::string
+ action_name (Action const & action);
+
+ /** A thin collimator element that applies a transverse aperture boundary defined
+ * by points of a polygon vertices.
+ * Particles outside the boundary are considered lost.
+ *
+ * @param action specify action of domain (transmit/absorb)
+ * @param vertices_xx array of coordinates of the horizontal vertex positions (m)
+ * @param vertices_yy array of coordinates of the vertical vertex positions (m)
+ * @param min_radius2 a minimum radius**2 below which all particles are transmitted
⬇️ Suggested change
- * @param min_radius2 a minimum radius**2 below which all particles are transmitted
+ * @param min_radius2x a minimum radius**2 below which all particles are transmitted
Doxygen requires that the name in the documentation here coincides with
the name of the function argument.
—
Reply to this email directly, view it on GitHub
<#1199 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4V5DBWQCFFZQSKUD6RWAL33ECAFAVCNFSM6AAAAACKEJHM3GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMJYGQ3TMNZXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
it should work on CPU and GPU and eliminate out-of-order initialization warnings.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ax3l
reviewed
Nov 6, 2025
| @@ -0,0 +1,46 @@ | |||
| ############################################################################### | |||
There was a problem hiding this comment.
Wonderful!
Please add your tests to examples/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the polygon aperture that defines an accepted region for transmitting particles defined by a set or vertices.