-
Notifications
You must be signed in to change notification settings - Fork 30
Element Selection Syntax: Position #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ax3l
wants to merge
3
commits into
BLAST-ImpactX:development
Choose a base branch
from
ax3l:topic-lattice-select-position
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Element Selection Syntax: Position #1183
ax3l
wants to merge
3
commits into
BLAST-ImpactX:development
from
ax3l:topic-lattice-select-position
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter by overlapping position range.
e081da7 to
94054fa
Compare
Implement a second-order, iterative Kahan–Babuška algorithm after Wikipedia
| sum_val = 0.0 | ||
| cs = 0.0 # first-order compensation for lost low-order bits | ||
| ccs = 0.0 # second-order compensation for further lost bits | ||
| c = 0.0 # temporary variable for first-order compensation |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
This assignment to 'c' is unnecessary as it is before this value is used.
This assignment to 'c' is unnecessary as it is before this value is used.
redefined
Error loading related location
Loading This assignment to 'c' is unnecessary as it is
redefined
Error loading related location
Loading | cs = 0.0 # first-order compensation for lost low-order bits | ||
| ccs = 0.0 # second-order compensation for further lost bits | ||
| c = 0.0 # temporary variable for first-order compensation | ||
| cc = 0.0 # temporary variable for second-order compensation |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
This assignment to 'cc' is unnecessary as it is before this value is used.
This assignment to 'cc' is unnecessary as it is before this value is used.
redefined
Error loading related location
Loading This assignment to 'cc' is unnecessary as it is
redefined
Error loading related location
Loading
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1182:
sis precise enough: add Kahan summation from [WIP] Compensated Sum for Global Coordinates #1195 andnp.isclose⏳