[WIP] Dashboard: add lattice defaults handler #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| LatticeDefaultsHandler._build_initial_defaults_list() | ||
| ) | ||
| state.dirty("lattice_defaults") | ||
| except Exception: |
Check notice
Code scanning / CodeQL
Empty except Note
| LatticeDefaultsHandler._build_initial_defaults_list() | ||
| ) | ||
| state.dirty("lattice_defaults") | ||
| except Exception: |
Check notice
Code scanning / CodeQL
Empty except Note
proy30
force-pushed
the
dashboard/add_lattice_defaults_handler
branch
2 times, most recently
from
c730881 to
a63d88c
Compare
assistance with codex
verify that lattice element is valid before adding
maybe ci will click too fast and it will not register
to reduce redundancy
make sure screenshots get uploaded in right place
for more information, see https://pre-commit.ci
prevent cluttering
utilizing same search bar code that was implemented in analysis page make ui same
some input defaults we might not want the user to modify at all ie beammonitor
instead of a very long single file with all of the logic
for more information, see https://pre-commit.ci
only apply changes if the user manually clicks apply
proy30
force-pushed
the
dashboard/add_lattice_defaults_handler
branch
from
9f96880 to
bf62342
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the lattice parameter defaults configurable within the dashboard. Previously, only the nslice parameter was exposed; with this change, all lattice defaults are now available for users to modify.
Current functionality (still WIP with ui design):
chrome_9eNttp5T6b.mp4
This gives dashboard users greater customization when building larger lattices.